Bitwarden CLI distributed through NPM has been compromised. Bitwarden Statement on Checkmarx Supply Chain Incident. (community.bitwarden.com)
from versionc@lemmy.world to selfhosted@lemmy.world on 23 Apr 20:11
https://lemmy.world/post/45986728

#selfhosted

threaded - newest

BlackEco@lemmy.blackeco.com on 23 Apr 20:23 next collapse

It has only been available for 2h30 on NPM, so unless you had the misfortune of installing the latest version in this short window, you should be fine. Thankfully people have been able to quickly catch this.

northendtrooper@lemmy.ca on 23 Apr 20:39 collapse

This is one of the reasons why I update a version or two behind. The other reason is because I’m lazy.

realitaetsverlust@piefed.zip on 23 Apr 20:50 next collapse

One lie and one truth in this sentence.

charade_you_are@sh.itjust.works on 23 Apr 21:10 collapse

Laziness has some obscure advantages

irmadlad@lemmy.world on 23 Apr 22:46 collapse

I update after I feel all the early adopters have worked out all the bugs for me.

ripcord@lemmy.world on 23 Apr 23:11 next collapse

That is a genuinely good strategy.

NotMyOldRedditName@lemmy.world on 23 Apr 23:48 collapse

Pretty much with anything ya.

Unless there’s some super important thing I need in the latest release, if my shit works and there’s no security vulnerability, im in no rush to update.

eager_eagle@lemmy.world on 23 Apr 20:41 next collapse

reposting the tl;dr I wrote from another community…

Yesterday, for about 1h30min (starting at 5:57pm ET / 21:57 UTC) anyone installing the latest version of the command line interface of bitwarden was installing malware.

The malware steals GitHub/npm tokens, .ssh, .env, shell history, GitHub Actions and cloud secrets, then exfiltrates the data to private domains and as GitHub commits and doesn’t seem to be targeting Bitwarden specifically, or user vaults.

There’s no evidence that end user vault data was accessed or at risk, or that production data or production systems were compromised, according to their official statement.

It seems there were 334 bitwarden CLI downloads in this time period, some or many of which might have been from bots, so this is a higher bound to the number of affected users.

Corngood@lemmy.ml on 23 Apr 21:09 next collapse

I really need to figure out a better sandboxing method for shells. It’s crazy to be things where my keys, browser data, shell history are all accessible.

I do try to use firejail where possible, but it’s quite cumbersome. Every so often I look for tools to help with this, but everything is oriented around making a specific program (e.g. Firefox, steam) work.

Anafabula@discuss.tchncs.de on 23 Apr 21:18 next collapse

For cli I just use podman(/docker) containers. Good enough and I don’t have to learn a new tool

eager_eagle@lemmy.world on 23 Apr 22:45 collapse

yeah, about twice a year I use the CLI to backup my vault, and I’ve never felt comfortable installing an npm package to handle my vault. Now I’m definitely sandboxing it in a rootless container without internet next time. And installing a week old version, or older.

Lojcs@piefed.social on 23 Apr 21:30 collapse

Me when I break into a bank to steal the employee wallets

atzanteol@sh.itjust.works on 23 Apr 21:06 next collapse

Npm is a fucking mess…

panda_abyss@lemmy.ca on 23 Apr 21:32 next collapse

Can we stop using npm now?

I swear to god the number of attacks like this or spawned from other attacks like this is fucking stupid. I’ve gender seen anything like it.

i_am_not_a_robot@discuss.tchncs.de on 23 Apr 22:13 next collapse

This problem has nothing to do with NPM. Checkmarx was compromised last month, and during that compromise there were malicious VS Code extensions published to Visual Studio Code Marketplace. A Bitwarden developer says that somebody ran one of those malicious extensions, and GitHub API keys were stolen which were used in publishing the malicious CLI package.

It’s probably better that it happened on NPM. If the CLI were only downloadable from the Bitwarden website, it would have likely taken longer for somebody to notice something was wrong.

realitaetsverlust@piefed.zip on 23 Apr 22:27 next collapse

Yes, but NPM has been had countless security problems, this isn’t a new problem. Even tho this instance is not a problem of NPM itself, it still has been proven as one of the most unreliable and insecure package managers out there.

wizardbeard@lemmy.dbzer0.com on 23 Apr 22:58 collapse

I’m not a particular fan of npm, but you’ll probably see this kind of thing with any package manager of similar size. More a matter of what’s the most attractive target than the package tech itself.

tjoa@feddit.org on 24 Apr 07:12 collapse

But why does NPM enable post install scripts by default? Why is there no way to define a minimum release age for dependency versions? It’s just poor design choices.

LodeMike@lemmy.today on 23 Apr 23:20 collapse

What a fucking asanine series of events.

LurkingLuddite@piefed.social on 23 Apr 22:51 next collapse

Genuine question. How is NPM more vulnerable than other repos? Haven’t similar supply chain attacks succeeded at least as well as this one through GitHub itself and even Linux package repos?

LodeMike@lemmy.today on 23 Apr 23:19 next collapse

There’s a lot of features that make it a better package manager but nobody cares. Every project has hundreds of dependencies and packages use a minimum, not exact, version.

LurkingLuddite@piefed.social on 23 Apr 23:42 collapse

That sounds more like bad practices from the community. It definitely has ways to use exact versions. Not the least of which the lock file. Or the shrinkwrap file which public packages should be using.

Serinus@lemmy.world on 24 Apr 00:16 next collapse

Then you’re waiting forever on vulnerability patches. Especially if there are layers, and each layer waits to update.

dustyData@lemmy.world on 24 Apr 00:52 collapse

Any security system based on expecting good behavior from people is sure to fail. If NPM has no estructural features to enforce safe behaviors, it is vulnerable by default. As no person using it will apply safe practices unless forced to. Specially if the default, easiest, less friction behavior, is inherently unsafe.

LurkingLuddite@piefed.social on 24 Apr 02:08 collapse

I wouldn’t say pulling in higher versions is unsafe unless an attack like this succeeds. Otherwise it’s only an annoyance.

hersh@literature.cafe on 23 Apr 23:22 next collapse

I don’t think you’ll find another major repo with so many real-world incidents though. Whether this is because of a systemic problem or just because it’s targeted more frequently, I’m not sure.

tempest@lemmy.ca on 23 Apr 23:53 collapse

As much as some people deride it Javascript is one of the most used languages on the planet.

This is basically the same as people thinking windows is less secure because it’s more often targeted.

JavaScript does have a bit of a problem with dependencies but it isn’t much different than other languages with built in package managers like rust. It’s just a bigger juicer target.

aesthelete@lemmy.world on 24 Apr 01:37 collapse

But Windows is less secure. Two things can be true at once. They are in the original topic too.

The Java ecosystem is massive and decades old and I don’t hear one iota of the shit about maven central that I hear about npm.

I guarantee that npm is full up with vibe coded bullshit at this point as well.

I’m not sure what it even takes to upload a package to npm. Not even a pulse. I honestly never looked into it because the whole ecosystem is so rancid.

EDIT: Look at how many shits in this are optional (and note the overall quality of the article as well): dev.to/…/publishing-your-first-npm-library-51k2. The ecosystem sucks.

NotMyOldRedditName@lemmy.world on 23 Apr 23:36 next collapse

Part of the problem is also how many packages people bring in, even for the simplest of things.

Serinus@lemmy.world on 24 Apr 00:15 collapse

Larger standard libraries do a lot. It’s a lot harder to sneak vulnerabilities into the basic C# or Java or C++ libraries than it is to add a vulnerability to something one dude maintains in the javascript ecosystem.

And since javascript libraries tend to be so small and focused, it’s become standard practice for even other libraries to pull in as many of those as they want.

And it stacks. Your libraries pull in other libraries which can pull in their own libraries. I had a project recently where I had maybe a dozen direct dependencies and they ended up pulling in 1,311 total libraries, largely all maintained by different people.

In a more sane ecosystem like C#, all the basics like string manipulation, email, or logging have libraries provided by Microsoft that have oversight when they’re changed. There can be better, third-party libraries for these things (log4net is pretty great), but they have to compete with their reputation and value over the standard library, which tends to be a high bar. And libraries made on top of that system are generally pulling all those same, certified standard libraries. So you pull in 3 libraries and only one of those pulls in another third party single library. And you end up with 4 total third party libraries.

Javascript just doesn’t really have a certified standard library.

(This certified standard library doesn’t have to be proprietary. Microsoft has made C# open source, and Linus Torvalds with the Linux Kernel Organization holds ultimate responsibility for the Linux kernel.)

vithigar@lemmy.ca on 24 Apr 02:35 next collapse

I will almost always choose .NET as my development platform when greenfielding a project for exactly this reason. It’s an incredibly robust standard library that virtually guarantees I won’t need to pull in a litany of additional utility libraries, and I can also expect that what libraries I do choose to bring in are highly unlikely to drag along a ridiculous parade of dependencies.

InternetCitizen2@lemmy.world on 24 Apr 04:15 collapse

will almost always choose .NET as my development

Do you feel its still worth learning now?

boonhet@sopuli.xyz on 24 Apr 07:06 collapse

Probably more worth than it was 15 years ago since you’re no longer restricted to Windows and it’s now open source. I’ve heard a lot of people say it’s nicer than Spring for enterprise stuff. Haven’t tried it much myself though. Was fairly easy to set up a simple API, but I then got distracted by other projects.

aesthelete@lemmy.world on 24 Apr 06:21 collapse

And since javascript libraries tend to be so small and focused

Lol, LMAO even

boonhet@sopuli.xyz on 24 Apr 07:03 collapse

Left-pad tho

Meron35@lemmy.world on 24 Apr 01:32 next collapse

As someone completely unfamiliar with the JavaScript mess, are these security issues specific to npm the actual repository or npm the package manager?

If it’s the latter, does using something else like yarn or bun instead help?

panda_abyss@lemmy.ca on 24 Apr 03:45 next collapse

I think npm allows installation scripts which do make this worse, as a package can run arbitrary command at install time.

anyhow2503@lemmy.world on 24 Apr 06:05 collapse

Npm has gotten a few config options that prevent this behaviour. We can only hope that they will become the default eventually.

delcaran@feddit.it on 24 Apr 05:17 collapse

It’s not, it’s a problem of every package manager that do not use sources and checksums, like rust and python. Take a look at this article that does a better job then me at explaining the situation.

anyhow2503@lemmy.world on 24 Apr 06:01 next collapse

The good news is that there already is a gold standard for supply chain security: the Go programming language.

Lmfao

bright_side_@piefed.world on 24 Apr 08:13 collapse

Competent standard lib + decentralized libs + checksum db.

While the article is a bit theatralic, it offers important arguments.

arcterus@piefed.blahaj.zone on 24 Apr 09:30 collapse

In a recent analysis, Adam Harvey found that among the 999 most popular crates on crates.io, around 17% contained code that do not match their code repository.

17%!

Let me rephrase this, 17% of the most popular Rust packages contain code that virtually nobody knows what it does (I can’t imagine about the long tail which receives less attention).

Given that he lied about the results of the analysis he is using to prove his point, I find it hard to trust anything in this article.

In the analysis, Harvey said only 8 repositories did not match their upstream repos. The other problems were issues like not including the VCS info, squashing history, etc.

EDIT: Also, I just noticed that he called it a “recent” analysis. It’s roughly a two year old analysis. I expect things have improved a bit since then, especially since part of the problem was packaging using older versions of Cargo.

anyhow2503@lemmy.world on 24 Apr 06:17 collapse

Npm probably has the biggest attack surface and many of the libraries hosted there are in extremely widespread use. They’ve taken some steps to mitigate these supply chain attacks, but as we’ve seen with more recent examples, it’s unrealistic to think they can be prevented completely. Most of these attacks use stolen developer credentials, which invalidates almost all potential security measures on the registry side and the best you can hope for is catching a malicious package quickly. To be clear: I think the JS ecosystem is uniquely positioned to be the prime target of supply chain attacks and while that doesn’t excuse the slow implementation of security measures from the npm team, the people arguing that other package managers and registries aren’t vulnerable to this have to be huffing fumes.

panda_abyss@lemmy.ca on 24 Apr 09:07 collapse

That’s fair, I won’t pretend pypi/pip and running uvx is much safer than npx.

But why hasn’t JavaScript established a defacto stdlib to replace ask the left pads and is even type packages?

I’ve taken a near zero dependency policy on my personal projects regardless, and now I run most code in containers to sandbox it.

superglue@lemmy.dbzer0.com on 23 Apr 22:31 next collapse

If I use the CLI through the bitwarden flatpak am I OK?

SaltySalamander@fedia.io on 23 Apr 21:41 next collapse

It would seem to me that npm simply cannot be trusted anymore.

elgordino@fedia.io on 23 Apr 23:16 next collapse

Everyone should be using minimumReleaseAge (or their package managers equivalent) to block installing recently updated packages.

savvywolf@pawb.social on 24 Apr 00:32 next collapse

Doesn’t that cause issues if a backdoor happened a few months ago and you should be updating to a recent fixed version?

Grass@sh.itjust.works on 24 Apr 04:54 next collapse

we can never win. it’s simply not allowed

anyhow2503@lemmy.world on 24 Apr 06:03 next collapse

It does. Enforcing a minimum package age can be useful for some applications, but the average user isn’t one of them.

amorpheus@lemmy.world on 24 Apr 09:21 collapse

Kind of, but if the backdoor is months old some hours don’t seem like they should matter.

KairuByte@lemmy.dbzer0.com on 24 Apr 01:18 collapse

Zero day goes brrrr

mazzilius_marsti@lemmy.world on 24 Apr 03:24 next collapse

lots of people recommend bitwarden, but i am more at peace with an offline password manager that i control like Keepass. You can also go the GNU route and use “pass” on Linux too

Or use a physical key like Yubikey to login

peskypry@lemmy.ml on 24 Apr 03:28 next collapse

No. Offline password managers are also suspectible to supply chain risk.

chicken@lemmy.dbzer0.com on 24 Apr 05:48 next collapse

I don’t think it uses npm though, that’s got to count for something

lka1988@lemmy.dbzer0.com on 24 Apr 07:42 next collapse

So is everything else. But KeePass has been a highly reputable password manager for close to 20 years now.

[deleted] on 24 Apr 09:47 collapse

.

mlg@lemmy.world on 24 Apr 03:47 next collapse

I’ve been trialing Vaultwarden for a while and while I do like the server sync setup and clean web access, the Bitwarden browser plugin is just okay despite being an “enterprise” solution. It misses probably about 20% of websites when creating a new account, forcing you to grab the password from the generator history and make a new entry manually.

KeepassXC is much better in that regard, and it’s almost as good as the default credential handler of Firefox, and it lets you set up a bunch of custom stuff to extend the functionality if you want. Plus it has some neat kbdx options aside from AES256.

Only downside is syncing, which I’m debating how I’ll deal with something better than syncthing on android (protocol is great, android makes it a PITA to have a background process if its not Google spyware).

KyuubiNoKitsune@lemmy.blahaj.zone on 24 Apr 08:25 collapse

It misses probably about 20% of websites when creating a new account, forcing you to grab the password from the generator history and make a new entry manually.

This makes me so fucking angry. How can a password manager be so bad at storing passwords, it’s like it’s only job. It even is generating the password for you! Aaaaaaaaaaaaaah!

moopet@sh.itjust.works on 24 Apr 08:41 collapse

TIL about the generator history

KyuubiNoKitsune@lemmy.blahaj.zone on 24 Apr 09:53 collapse

Not super helpful, because every time you open it, it generates a new one, so how do you know which one is the one it generated?

aeiou_ckr@lemmy.world on 24 Apr 04:00 next collapse

Only if yubibkey worked for more than the handful of sites/services. I have one for my bitwarden as majority of places want to send a text or us totp.

Samskara@sh.itjust.works on 24 Apr 09:45 collapse

I use Enpass since 1Password became shit. It’s alright.

sturmblast@lemmy.world on 24 Apr 03:34 next collapse

I’ll just keep using keepass.

RagingRobot@lemmy.world on 24 Apr 04:06 collapse

Keep ass?

InternetCitizen2@lemmy.world on 24 Apr 04:12 next collapse

Yeah, as in keep it closed so you don’t get fucked by the hackers.

sturmblast@lemmy.world on 24 Apr 04:13 collapse

You know it

quick_snail@feddit.nl on 24 Apr 05:41 next collapse

Don’t. Use. Npm.

That applies to pip and crate and all the other shitty lang package managers that totally fail at security

captcha_incorrect@lemmy.world on 24 Apr 05:43 next collapse

What should be used instead?

grandma@sh.itjust.works on 24 Apr 06:37 collapse

Easy, just vendor all your dependencies! Can’t have a supply chain attack if you are the supply chain.

wizzim@infosec.pub on 24 Apr 07:29 next collapse

Unfortunately I have to use node for home project (Jellyfin tizen)

I was wondering: would it be possible to run node in a sandbox to lower the scope of the attack? (i.e. not compromise my home computer) Or is maybe a full VM a better solution?

captcha_incorrect@lemmy.world on 24 Apr 09:33 collapse

Wouldn’t verion pinning solve this problem?

rmrf@lemmy.ml on 24 Apr 11:22 collapse

Honestly just fine use computers at all, completely eliminate the remote attack vector. And only drink rain water since city water can be compromised.

Or, recognize this is a normal part of using software and have more than 1 thing between you and a breach

Quique@lemmy.world on 24 Apr 07:19 collapse

Does this include the brew version?